nisse-dev: a settled reply posted top-level is no point to answer either
nisse-review's review of #169: a reply quoting a top-level point, or one Gitea refused on its line, arrives through list_comments, so answering it would start the thank-you loop again. Also records what the live Gitea showed: resolving is per comment, and resolving again is a 204. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
This commit is contained in:
1 parent
33d030590d
commit
0694b47c34
4 files changed
+24
-2
No files matched your search
@@ -97,7 +97,9 @@ SETTLED_MARKER = "<!-- nisse-review: settled -->"
|
||||
|
||||
def to_resolve(notes: list[ReviewNote]) -> list[int]:
|
||||
"""The ids of the unresolved line comments in threads a settled reply
|
||||
closed: every comment on that path:line, as Gitea groups a thread."""
|
||||
closed: every comment on that path:line, as Gitea groups a thread.
|
||||
Gitea resolves one comment at a time (seen on 28.2: the rest of the
|
||||
thread still reports no resolver), and resolving one again is a 204."""
|
||||
settled = {
|
||||
n.where for n in notes if n.key.startswith("line-") and SETTLED_MARKER in n.body
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user