nisse-dev: a settled reply posted top-level is no point to answer either
nisse-review's review of #169: a reply quoting a top-level point, or one Gitea refused on its line, arrives through list_comments, so answering it would start the thank-you loop again. Also records what the live Gitea showed: resolving is per comment, and resolving again is a 204. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
This commit is contained in:
1 parent
33d030590d
commit
0694b47c34
4 files changed
+24
-2
No files matched your search
@@ -1111,6 +1111,8 @@ class LoopAgent:
|
||||
loop = replace(loop, comments=comment.id)
|
||||
if comment.author == self._account:
|
||||
continue # its own replies
|
||||
if SETTLED_MARKER in comment.body:
|
||||
continue # a settled reply posted top-level: nothing to answer
|
||||
if comment.author not in self._gitea_operators:
|
||||
point = f"c{comment.id}"
|
||||
loop = self._peer_point(
|
||||
|
||||
@@ -293,3 +293,20 @@ def test_a_refused_resolve_leaves_the_thread_and_is_tried_again(
|
||||
forge.refuse_resolve = False
|
||||
agent.watch()
|
||||
assert forge.resolved == [11, 12, 13]
|
||||
|
||||
|
||||
def test_a_settled_reply_posted_top_level_is_not_a_point(
|
||||
world: dict[str, Any],
|
||||
) -> None:
|
||||
"""One quoting a top-level point, or Gitea refused on its line: there's
|
||||
no thread to resolve, and answering it would start the loop again."""
|
||||
forge: Forge = world["forge"]
|
||||
agent, _, pr = published(world)
|
||||
forge.comments[pr] = [
|
||||
Comment(
|
||||
15, REVIEWER, f"> nisse-dev:\n> Done.\n\nThanks.\n{SETTLED_MARKER}", "t"
|
||||
)
|
||||
]
|
||||
agent.watch()
|
||||
loop = loop_of(the_item(world))
|
||||
assert (the_item(world).position, loop.points) == (WAITING, ())
|
||||
Reference in new issue
Block a user