nisse-review: later reviews, replies, rounds, stop and review (M7.5)
Back on a PR it reviewed: a new head gets a later review of the commits since (each one's diff, through the API) and of its earlier points; what was said since gets replies, answered where it was said or skipped with a reason. It signs off once and stays quiet while still happy. Past tuning.review.max_rounds it sums up for the operator and goes quiet, until a push or someone other than the PR's author joins in. An operator's `stop` quiets it; `review` asks for a fresh review. Reviews carry numbered markers and replies their point's key, so recovery posts nothing twice. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
This commit is contained in:
1 parent
7e73b8fb37
commit
37bbac7e72
14 files changed
+1268
-157
No files matched your search
@@ -660,9 +660,40 @@ a bot's comment needs a reply.
|
||||
inline too.
|
||||
- **Tests:** `test_loop_peers.py` over the fake Gitea.
|
||||
|
||||
**M7.5 Discussion and rounds.** *Pre-approved.* Later reviews of what changed and
|
||||
**M7.5 Discussion and rounds.** *Done.* Later reviews of what changed and
|
||||
of earlier points, replies on threads, the round cap and its reset, `stop` and
|
||||
`review` on a PR (R1, R2, R5).
|
||||
`review` on a PR (R1, R2, R5):
|
||||
|
||||
- **What wakes it:** each round, intake reads what was said on every open PR
|
||||
(top-level comments, review bodies, line comments) and keeps the keys it has
|
||||
taken in; anything new but its own is a point to answer. A run is due for a
|
||||
PR never reviewed (or `review`ed), a new head (a **later review**, after its
|
||||
CI as before), or new points at the same head (**replies**, no CI wait).
|
||||
- **A later review** is given the commits since its last review with each
|
||||
one's diff (Gitea's compare lists them; the per-commit diff comes through the
|
||||
API, since the web's compare diff takes no token), or the whole diff if they
|
||||
can't be listed, and its earlier points with what was said on their lines.
|
||||
- **Replies:** `reply` answers a point where it was made (inline on its line,
|
||||
else quoting it), `skip` leaves it with a reason, `done` ends; every point is
|
||||
answered or skipped before a run may end. Each reply carries its point's key,
|
||||
so a run re-done after a crash answers nothing twice.
|
||||
- **Sign-off:** `sign_off` posts a short review when there is nothing to raise;
|
||||
while it stays happy, a later review offers `still_happy`, which posts nothing
|
||||
(operator: no repeated LGTMs).
|
||||
- **Rounds:** each review, and each run that replied, is a round. Past
|
||||
`tuning.review.max_rounds`, the next run sums up what is still open for the
|
||||
operator (`post_summary`, as a review) and the item goes quiet (`capped`). A
|
||||
push, or a comment from anyone but the reviewer and the PR's author (bots
|
||||
included: the operator wants to see how the model handles them), resets it.
|
||||
- **`stop` and `review`:** an operator's whole comment; acknowledged with a 👍
|
||||
reaction. `stop` quiets the item through pushes and comments; `review` asks
|
||||
for a fresh review of the whole PR, and retries a failed item.
|
||||
- **Durability:** reviews carry a numbered marker (`<!-- nisse-review: {head}
|
||||
#{n} -->`, the first in M7.3's form), so recovery asks Gitea about the right
|
||||
one; items from before M7.5 take what was already said as heard.
|
||||
- **Tests:** `test_review_rounds.py`, including a no-dead-end walk over every
|
||||
position; the live smoke test adds a push and a question, and checks the
|
||||
later review at the new head.
|
||||
|
||||
**M7.6 Deployment.** *Waits for the agent host (Phase 6).* Its image, container,
|
||||
Gitea account and secrets (R5).
|
||||
|
||||
Reference in new issue
Block a user