M2.8: switch over to the new loop
nisse-dev now runs only the conversational loop. The gated state machine it was built alongside is gone: - Removed control.py, planner.py, executor.py, approvals.py, gates.py (command_form moves to loop/reader.py), publish.py and poller.py, the old assembly in agent.py (its shared helpers move to loop/build.py), the store's state-machine view (get_state, transition), their tests, the old end-to-end and live planning/milestone/gate tests, and specs/orchestrator.qnt with its scenarios. - Roles are driver, helper, expert and classifier; driver is required. loop:, roles.planner, roles.executor and tuning.executor are refused with what to use instead; tuning.driver takes the turn cap and failure limit. - The benchmark and the capability matrix measure the driver: the loop's own system prompt and tools, the task's plan as the agreed restatement. Task plans end with finish_milestone, so earlier runs show as (old); stored runs' executor tuning reads as the driver's. - A delegation on the loop records what its helper's alias resolved to (L9), as the old path's did. - The dump shows a work item's revision and what it waits for. - Behaviour the old tests covered and the loop shares stays covered: driver runs that fail on a model call, stop mid-turn, reset the failure count; go-aheads ignoring case and punctuation; a request too big to fit is never sent; the assembly tests, now on build_loop_agent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE
This commit is contained in:
1 parent
09232dcbdd
commit
6ae2375194
89 files changed
+951
-8592
No files matched your search
@@ -29,10 +29,21 @@ def events(stream: io.StringIO) -> list[dict]:
|
||||
return [json.loads(line) for line in stream.getvalue().splitlines()]
|
||||
|
||||
|
||||
def start_item(
|
||||
store: StateStore, item_id: str, *, scope: str | None = None, cause: str
|
||||
) -> None:
|
||||
"""Open a work item, make it the active one and set it running."""
|
||||
store.open_work_item(
|
||||
item_id, title=item_id, scope=scope, position="IDLE", cause=cause
|
||||
)
|
||||
store.set_active(item_id, cause=cause)
|
||||
store.update_work_item(item_id, position="RUNNING", data={}, cause=cause)
|
||||
|
||||
|
||||
def test_every_event_carries_the_envelope(
|
||||
store: StateStore, stream: io.StringIO
|
||||
) -> None:
|
||||
store.transition("PLANNING_ARCH", cause="operator command: use demo")
|
||||
start_item(store, "demo-1", cause="issue assigned")
|
||||
intent_id = store.begin_intent("push_branch", {}, cause="milestone execution")
|
||||
store.commit_intent(intent_id, cause="push verified")
|
||||
for event in events(stream):
|
||||
@@ -40,16 +51,20 @@ def test_every_event_carries_the_envelope(
|
||||
assert event["agent"] == "nisse-dev"
|
||||
|
||||
|
||||
def test_transition_logs_from_to_and_cause(
|
||||
def test_a_position_change_logs_from_to_and_cause(
|
||||
store: StateStore, stream: io.StringIO
|
||||
) -> None:
|
||||
store.transition("PLANNING_ARCH", cause="operator command: use demo", project="d")
|
||||
store.transition("AWAIT_ARCH_SIGNOFF", cause="plan submitted", project="d")
|
||||
start_item(store, "d-1", scope="d", cause="issue assigned")
|
||||
store.update_work_item("d-1", position="WAITING", data={}, cause="restated")
|
||||
# Opening the work item logs its own events first (work_item.open, .switch).
|
||||
first, second = [e for e in events(stream) if e["event"] == "state.transition"]
|
||||
assert (first["from"], first["to"]) == ("IDLE", "PLANNING_ARCH")
|
||||
assert (second["from"], second["to"]) == ("PLANNING_ARCH", "AWAIT_ARCH_SIGNOFF")
|
||||
assert second["cause"] == "plan submitted"
|
||||
assert (first["from"], first["to"]) == ("IDLE", "RUNNING")
|
||||
assert (second["from"], second["to"], second["project"]) == (
|
||||
"RUNNING",
|
||||
"WAITING",
|
||||
"d",
|
||||
)
|
||||
assert second["cause"] == "restated"
|
||||
|
||||
|
||||
def test_intent_lifecycle_events(store: StateStore, stream: io.StringIO) -> None:
|
||||
@@ -63,9 +78,9 @@ def test_intent_lifecycle_events(store: StateStore, stream: io.StringIO) -> None
|
||||
|
||||
|
||||
def test_task_id_threads_through_events(store: StateStore, stream: io.StringIO) -> None:
|
||||
store.transition("IDLE", cause="boot")
|
||||
store.open_work_item("general", title="general", position="IDLE", cause="boot")
|
||||
store.oplog.task_id = "task-42"
|
||||
store.transition("PLANNING_ARCH", cause="operator command")
|
||||
start_item(store, "task-42", cause="issue assigned")
|
||||
before, *during = events(stream)
|
||||
assert before["task_id"] is None
|
||||
assert {e["task_id"] for e in during} == {"task-42"}
|
||||
@@ -119,12 +134,7 @@ def test_literal_log_lines_for_human_readability(
|
||||
|
||||
monkeypatch.setattr("nisse_dev.oplog.datetime", _FrozenDatetime)
|
||||
|
||||
store.transition(
|
||||
"PLANNING_ARCH",
|
||||
cause="operator command: use demo",
|
||||
project="demo",
|
||||
data={"task_id": "demo-m2"},
|
||||
)
|
||||
start_item(store, "demo-m2", scope="demo", cause="issue assigned: demo#2")
|
||||
store.oplog.task_id = "demo-m2"
|
||||
intent_id = store.begin_intent(
|
||||
"push_branch", {"branch": "milestone-2"}, cause="milestone 2 execution"
|
||||
@@ -135,20 +145,20 @@ def test_literal_log_lines_for_human_readability(
|
||||
(
|
||||
'{"ts": "2026-09-05T12:00:00+00:00", "agent": "nisse-dev",'
|
||||
' "event": "work_item.open", "task_id": null,'
|
||||
' "cause": "operator command: use demo",'
|
||||
' "cause": "issue assigned: demo#2",'
|
||||
' "work_item": "demo-m2", "scope": "demo"}'
|
||||
),
|
||||
(
|
||||
'{"ts": "2026-09-05T12:00:00+00:00", "agent": "nisse-dev",'
|
||||
' "event": "work_item.switch", "task_id": null,'
|
||||
' "cause": "operator command: use demo",'
|
||||
' "cause": "issue assigned: demo#2",'
|
||||
' "from": null, "to": "demo-m2"}'
|
||||
),
|
||||
(
|
||||
'{"ts": "2026-09-05T12:00:00+00:00", "agent": "nisse-dev",'
|
||||
' "event": "state.transition", "task_id": null,'
|
||||
' "cause": "operator command: use demo",'
|
||||
' "from": "IDLE", "to": "PLANNING_ARCH", "project": "demo"}'
|
||||
' "cause": "issue assigned: demo#2",'
|
||||
' "from": "IDLE", "to": "RUNNING", "project": "demo"}'
|
||||
),
|
||||
(
|
||||
'{"ts": "2026-09-05T12:00:00+00:00", "agent": "nisse-dev",'
|
||||
|
||||
Reference in new issue
Block a user