Match approvals and commands regardless of case and trailing punctuation
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 1m15s
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 1m15s
A phone keyboard's "Approve" did not match the approval pattern, so it counted as rejection feedback and threw the plan away; "Stop" did not reach the cancel flag; other capitalised commands got a hint instead of acting. gates.command_form() is how a message reads as a command: case, surrounding whitespace, inner runs of whitespace and a trailing '.' or '!' do not matter. The approval gate and every command match in the orchestrator (stop, status, abandon, use, start milestone, next milestone, project complete, the restart choices) use it. Only matching changes: the project name in 'use <name>' keeps its case, and feedback and answers are recorded and passed on as written. A stale revision is still refused, and approval still needs the whole message to be the command. Closes #64. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE
This commit is contained in:
1 parent
b893fba342
commit
6afd0cc914
5 files changed
+76
-15
No files matched your search
@@ -269,3 +269,17 @@ def test_use_starts_over_when_nothing_is_pending(h: Harness) -> None:
|
||||
h.store.transition(AWAIT_INPUT, cause="forced", project="demo", data={})
|
||||
h.transport.receive("don", "use demo")
|
||||
assert h.state == AWAIT_ARCH_SIGNOFF
|
||||
|
||||
|
||||
def test_commands_ignore_case_but_the_project_name_keeps_it(h: Harness) -> None:
|
||||
h.transport.receive("don", "Use Demo.")
|
||||
assert h.state == AWAIT_ARCH_SIGNOFF
|
||||
assert h.store.get_state().project == "Demo"
|
||||
h.transport.receive("don", "Status")
|
||||
assert "AWAIT_ARCH_SIGNOFF" in h.outbound_texts()[-1]
|
||||
h.transport.receive("don", "Approve")
|
||||
h.transport.receive("don", "Approve.")
|
||||
h.transport.receive("don", "Start Milestone 1")
|
||||
assert h.state == PR_OPEN
|
||||
h.transport.receive("don", "Project Complete!")
|
||||
assert h.state == IDLE
|
||||
Reference in new issue
Block a user