Bind approvals and feedback to the revision they were about

Fixes counterexamples 1-4 from specs/orchestrator.qnt: a repeated
'approve', 'approve rev-1' meant for the architecture, approving on both
channels, and 'approve' plus an afterthought all landed on the next
plan, one the operator had not seen.

- Revisions are numbered across the work item (A4 already required
  monotonic tags; the code numbered per gate), so rev-N names one plan.
- Each reply is stamped on arrival with the revision that was up: in
  Matrix the one whose approval request had been sent (a plain value
  the transport thread reads, restored on boot), in Gitea the latest
  plan comment older than the reply (board.posts).
- Gate.evaluate applies a reply that names no revision only if its stamp
  is the current revision. Otherwise an approval is not applied and
  feedback rejects nothing (it is still in the transcript), and the
  agent says which revision is up. 'approve rev-N' binds by its number.
- Spec A4 states both rules. The model applies them; scenarios 1-4 now
  expect the properties to hold, and both held over 200,000 random
  traces and Apalache's exhaustive check to depth 8.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE

nisse-dev/tests/test_quint_counterexamples.py

@@ -191,7 +191,6 @@ class Agent:
 XFAIL = pytest.mark.xfail(strict=True, reason="counterexample; fix pending")
 
 
-@XFAIL
 def test_double_approve_approves_an_unseen_plan(tmp_path: Path) -> None:
     """doubleApproveApprovesAnUnseenPlanTest"""
     worker = QueueingWorker()
@@ -205,7 +204,6 @@ def test_double_approve_approves_an_unseen_plan(tmp_path: Path) -> None:
     assert not agent.gate().get("approved")
 
 
-@XFAIL
 def test_named_revision_approves_the_wrong_gate(tmp_path: Path) -> None:
     """namedRevisionApprovesTheWrongGateTest"""
     worker = QueueingWorker()
@@ -218,7 +216,6 @@ def test_named_revision_approves_the_wrong_gate(tmp_path: Path) -> None:
     assert not agent.gate().get("approved")
 
 
-@XFAIL
 def test_approval_on_both_channels_approves_the_next_plan(tmp_path: Path) -> None:
     """approvalOnBothChannelsApprovesTheNextPlanTest"""
     gitea = FakeGitea()
@@ -237,7 +234,6 @@ def test_approval_on_both_channels_approves_the_next_plan(tmp_path: Path) -> Non
     assert not agent.gate().get("approved")
 
 
-@XFAIL
 def test_an_afterthought_rejects_the_next_plan(tmp_path: Path) -> None:
     """anAfterthoughtRejectsTheNextPlanTest"""
     worker = QueueingWorker()
@@ -250,7 +246,7 @@ def test_an_afterthought_rejects_the_next_plan(tmp_path: Path) -> None:
     # The note was about the architecture; the milestone plan was not
     # rejected by it.
     assert agent.state == AWAIT_MILESTONE_SIGNOFF
-    assert agent.gate().get("rev") == 1
+    assert agent.gate().get("rev") == 2  # arch was rev-1; not re-planned
 
 
 @XFAIL