M3.3: the trust dial (the agent merges approved PRs)
A project's trust.merge is operator (the default) or approved (L3, D5, #65). Set to approved, the harness, never the model, merges a PR in the PR watch once an approving review from a gitea.operators account is on its current commit, its checks pass (none at all counts; pending waits) and it's mergeable; the item then goes on as after any merge. Each reason to hold off (failed checks, conflicts, a refused merge) is said once per commit. Gitea enforces it: protection requires approvals from an operators-only whitelist and dismisses stale ones. At start, for each approved project, the agent checks by behaviour that its own unapproved merge is refused, with a throwaway branch and PR made through the API (never the workspace); if it isn't refused, the operator merges until a restart. - gitea: approvals, combined check status, a PR's head commit and mergeability, API-made branches and their deletion. - Test and bring-up repositories get the protection. - Tests: the decision (unit), the hard wall on a real Gitea (test_trust_live), an e2e test where the operator only approves, and a walk property, merges_only_approved, checked against a mutant that ignores which commit was approved. Closes #65 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE
This commit is contained in:
1 parent
21cbf1682c
commit
ab469b60bb
17 files changed
+733
-11
No files matched your search
@@ -61,7 +61,9 @@ def running(
|
||||
ssh_host: SSHHost,
|
||||
tmp_path: Path,
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
request: pytest.FixtureRequest,
|
||||
) -> Iterator[tuple[RunningLoop, InMemoryTransport, str]]:
|
||||
mode = request.node.get_closest_marker("merge")
|
||||
run = uuid.uuid4().hex[:8]
|
||||
stack = contextlib.ExitStack()
|
||||
# Kept outside pytest's temp directories, which pytest prunes, so a
|
||||
@@ -80,6 +82,7 @@ def running(
|
||||
push_key=fresh.push_key,
|
||||
workspace=Path(f"/tmp/nisse-e2e-{run}/sandbox"),
|
||||
build_host=build_host(ssh_host),
|
||||
merge=mode.args[0] if mode else "operator",
|
||||
)
|
||||
config = replace(
|
||||
live_config,
|
||||
@@ -229,6 +232,27 @@ class Operator:
|
||||
state = gitea._request("GET", f"/repos/{repo}/issues/{issue}")["state"]
|
||||
assert state == "closed"
|
||||
|
||||
def approve_and_wait(self, issue: int) -> None:
|
||||
"""Approve the item's PR, as the operator, and see the agent merge
|
||||
it and close the item (trust.merge: approved)."""
|
||||
gitea, repo = self.agent.gitea, self.agent.config.projects[0].repo
|
||||
as_operator = operator_gitea(self.agent.config.gitea_url)
|
||||
pr = loop_of(self.item(issue)).pr
|
||||
as_operator._request(
|
||||
"POST", f"/repos/{repo}/pulls/{pr}/reviews", json={"event": "APPROVED"}
|
||||
)
|
||||
deadline = time.monotonic() + DEADLINE_S
|
||||
nudges = 0
|
||||
while self.item(issue).status != "closed" and time.monotonic() < deadline:
|
||||
self.tick()
|
||||
if loop_of(self.item(issue)).wait == ANSWER:
|
||||
nudges += 1
|
||||
assert nudges <= MAX_ANSWERS, f"never closed: {self.last()}"
|
||||
self.say("It's merged; please close the item.", issue)
|
||||
self.settle()
|
||||
assert gitea._request("GET", f"/repos/{repo}/pulls/{pr}")["merged"]
|
||||
assert self.item(issue).outcome == "completed"
|
||||
|
||||
def tidy(self, issues: list[int], prs: list[int]) -> None:
|
||||
"""Leave the sandbox tidy: whatever is still open gets closed."""
|
||||
gitea, repo = self.agent.gitea, self.agent.config.projects[0].repo
|
||||
@@ -690,3 +714,28 @@ def test_a_question_leaves_the_restatement_up(
|
||||
assert loop_of(operator.item(issues[0])).started
|
||||
finally:
|
||||
operator.tidy(issues, [])
|
||||
|
||||
|
||||
@pytest.mark.merge("approved")
|
||||
def test_an_approved_pr_is_merged_by_the_agent(
|
||||
running: tuple[RunningLoop, InMemoryTransport, str],
|
||||
) -> None:
|
||||
"""M3.3: on a project set to merge approved PRs, the operator only
|
||||
approves; the agent merges and closes the item."""
|
||||
agent, transport, run = running
|
||||
operator = Operator(agent, transport)
|
||||
repo = agent.config.projects[0].repo
|
||||
as_operator = operator_gitea(agent.config.gitea_url)
|
||||
issue = None
|
||||
pr = 0
|
||||
try:
|
||||
issue = as_operator.create_issue(repo, f"vowels_{run}", task(run))
|
||||
as_operator.assign_issue(repo, issue, agent.account)
|
||||
operator.tick()
|
||||
item = operator.drive_until(MERGE, issue)
|
||||
pr = loop_of(item).pr
|
||||
operator.approve_and_wait(issue)
|
||||
said = " ".join(m.text for m in transport.outbound)
|
||||
assert f"Merged PR #{pr} after" in said
|
||||
finally:
|
||||
operator.tidy([issue] if issue is not None else [], [pr] if pr else [])
|
||||
Reference in new issue
Block a user