M7.4: nisse-dev answers a peer
Anyone's comment on an item's PR but an operator's (and its own) is a peer's point (D5, L11): kept on the item with an id, in the transcript as a `peer` message labelled with its author, and never an instruction. The driver answers each with answer_peer, inline on its line or quoting it, or skips it with skip_peer and a recorded reason. A run going back to waiting with points open is reminded once; then the harness lists them on the PR. A peer's comment wakes the item; a wake by peers alone goes back to the same wait quietly, with one line in the thread. The operator's inline comments are now answered inline too. Also corrects ci.yml's header: a push to main runs no end-to-end tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
This commit is contained in:
1 parent
5126f0717d
commit
ecff719f1a
10 files changed
+655
-69
No files matched your search
@@ -632,8 +632,22 @@ waits until two exist to compare. Moved, unchanged in behaviour:
|
||||
(`test_review_live.py`, `NISSE_REVIEW_GITEA_TOKEN`) has the local model
|
||||
review a PR in a fresh test repository.
|
||||
|
||||
**M7.4 `nisse-dev` answers a peer.** *Pre-approved.* Peer comments labelled as a
|
||||
peer's, answered point by point with a change or a reason (D5, R4).
|
||||
**M7.4 `nisse-dev` answers a peer.** *Done.* Anyone's comment but an operator's
|
||||
is a peer's point (D5, L11), not only `nisse-review`'s: settled with the operator,
|
||||
since only accounts they made can log in to Gitea, with the model deciding whether
|
||||
a bot's comment needs a reply.
|
||||
- Each top-level comment, review body and inline comment is a point (P1, P2, …)
|
||||
on the item, in the transcript as a `peer` message labelled with its author
|
||||
(`nisse_core.log.views`). Its own comments are skipped.
|
||||
- `answer_peer` answers where the point was made: inline on its line, or quoting
|
||||
it. `skip_peer` records why no reply is needed. The thread gets one line per
|
||||
run on what was answered and skipped.
|
||||
- A run going back to waiting with points open is reminded once; then the harness
|
||||
lists them on the PR. A merge or close drops the rest, with a fact.
|
||||
- A peer's comment wakes the item; a wake by peers alone returns to the same wait
|
||||
without a note to the operator. The operator's inline comments are now answered
|
||||
inline too.
|
||||
- **Tests:** `test_loop_peers.py` over the fake Gitea.
|
||||
|
||||
**M7.5 Discussion and rounds.** *Pre-approved.* Later reviews of what changed and
|
||||
of earlier points, replies on threads, the round cap and its reset, `stop` and
|
||||
|
||||
Reference in new issue
Block a user