CI runs nisse-review's live test
scripts/e2e.sh ran only test_end_to_end_loop.py, and the integration step excludes e2e-marked tests, so test_review_live.py (M7.3) never ran in CI. The script now runs every e2e-marked test under tests/integration, and the review test is a smoke test: about a minute on the local model, and the only check that the review account, its token and its read-only refusal work. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
This commit is contained in:
1 parent
49a40a4b7d
commit
fe9c7c19a1
3 files changed
+9
-4
No files matched your search
@@ -629,8 +629,10 @@ waits until two exist to compare. Moved, unchanged in behaviour:
|
|||||||
- **Bring-up:** `scripts/review-bringup.sh`, a transient systemd unit from the
|
- **Bring-up:** `scripts/review-bringup.sh`, a transient systemd unit from the
|
||||||
exported code; config and secrets in `/root/nisse-review`.
|
exported code; config and secrets in `/root/nisse-review`.
|
||||||
- **Tests:** unit tests over a fake Gitea and a scripted model; a live test
|
- **Tests:** unit tests over a fake Gitea and a scripted model; a live test
|
||||||
(`test_review_live.py`, `NISSE_REVIEW_GITEA_TOKEN`) has the local model
|
(`test_review_live.py`, `NISSE_REVIEW_GITEA_TOKEN`, the test reviewer
|
||||||
review a PR in a fresh test repository.
|
account's) has the local model review a PR in a fresh test repository. It is a
|
||||||
|
smoke test, run by `scripts/e2e.sh` on every PR (until #152 it never ran in CI:
|
||||||
|
the script ran only the loop's file).
|
||||||
|
|
||||||
**M7.4 `nisse-dev` answers a peer.** *Done.* Anyone's comment but an operator's
|
**M7.4 `nisse-dev` answers a peer.** *Done.* Anyone's comment but an operator's
|
||||||
is a peer's point (D5, L11), not only `nisse-review`'s: settled with the operator,
|
is a peer's point (D5, L11), not only `nisse-review`'s: settled with the operator,
|
||||||
|
|||||||
+2
-1
@@ -53,7 +53,8 @@ print(i["spend"], i.get("max_budget"))' 2>/dev/null) || echo "? ?"
|
|||||||
}
|
}
|
||||||
read -r before budget < <(spend)
|
read -r before budget < <(spend)
|
||||||
status=0
|
status=0
|
||||||
uv run pytest -m e2e -rs tests/integration/test_end_to_end_loop.py "$@" || status=$?
|
# Every e2e-marked test: the agents' loops and nisse-review's live review.
|
||||||
|
uv run pytest -m e2e -rs tests/integration "$@" || status=$?
|
||||||
read -r after _ < <(spend)
|
read -r after _ < <(spend)
|
||||||
python3 -c "
|
python3 -c "
|
||||||
b, a, cap = '$before', '$after', '$budget'
|
b, a, cap = '$before', '$after', '$budget'
|
||||||
|
|||||||
@@ -21,7 +21,9 @@ from nisse_review.build import StartupError, build
|
|||||||
from nisse_review.config import ReviewConfig
|
from nisse_review.config import ReviewConfig
|
||||||
from nisse_review.review import marker
|
from nisse_review.review import marker
|
||||||
|
|
||||||
pytestmark = [pytest.mark.integration, pytest.mark.e2e]
|
# Smoke: every PR runs it (about a minute on the local model), the only
|
||||||
|
# check that the review account, its token and its read-only refusal work.
|
||||||
|
pytestmark = [pytest.mark.integration, pytest.mark.e2e, pytest.mark.smoke]
|
||||||
|
|
||||||
|
|
||||||
def review_gitea(url: str) -> GiteaClient:
|
def review_gitea(url: str) -> GiteaClient:
|
||||||
|
|||||||
Reference in new issue
Block a user