Re-attaching a watch from inside its own callback stalls ~25 s #70

New Issue

2026-09-29T17:33:58Z

dev-agent commented

2026-09-29 17:33:58 +00:00

Noticed while doing #68.

When a Gitea comment approves a plan, the handler runs on the worker while the poller's thread waits in worker.call. Approving the architecture plans the milestone and posts it, and _post_plan_to_board calls _watch("plan", …). That replaces the poller that delivered the comment: _unwatch → CommentPoller.stop() joins that poller's thread, which is itself blocked waiting on this job. The join times out after interval_s + 5 (25 s by default) and work carries on, so nothing breaks, but a Gitea approval stalls the agent for ~25 s.

Options:

keep the same poller and move it to the new revision (update its cursor/priming) instead of replacing it;
or, in stop(), skip the join when called from the poller's own delivery path, so the thread exits by itself after the callback returns.

Test: approve a plan through a Gitea comment with a real threaded poller and assert the handler returns well under the join timeout.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE

Noticed while doing #68. When a Gitea comment approves a plan, the handler runs on the worker while the poller's thread waits in `worker.call`. Approving the architecture plans the milestone and posts it, and `_post_plan_to_board` calls `_watch("plan", …)`. That replaces the poller that delivered the comment: `_unwatch` → `CommentPoller.stop()` joins that poller's thread, which is itself blocked waiting on this job. The join times out after `interval_s + 5` (25 s by default) and work carries on, so nothing breaks, but a Gitea approval stalls the agent for ~25 s. **Options:** - keep the same poller and move it to the new revision (update its cursor/priming) instead of replacing it; - or, in `stop()`, skip the join when called from the poller's own delivery path, so the thread exits by itself after the callback returns. **Test:** approve a plan through a Gitea comment with a real threaded poller and assert the handler returns well under the join timeout. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE

dev-agent referenced this issue

2026-09-30 21:06:14 +00:00

Propose the Development Plan #84

dev-agent referenced this issue

2026-10-02 19:41:48 +00:00

Rework the Development Plan around live testing #92

dev-agent referenced this issue

2026-10-02 23:53:02 +00:00

Milestones and review in the new loop (M2.1, PR C) #98

Sign in to join this conversation.