Spec: nisse-review (Part R) before nisse-ops #146
@@ -891,9 +891,9 @@ Two agents can argue forever, so a PR's exchanges are capped.
|
|||||||
- **A round** is one review or set of replies the reviewer posts. After a capped
|
- **A round** is one review or set of replies the reviewer posts. After a capped
|
||||||
number of rounds (a tuning value) it posts a summary of what is still open, for
|
number of rounds (a tuning value) it posts a summary of what is still open, for
|
||||||
the operator, and stops answering on that PR.
|
the operator, and stops answering on that PR.
|
||||||
- **Anyone else commenting resets the count:** someone other than the reviewer
|
- **The count resets** when someone other than the reviewer and the PR's agent
|
||||||
|
|
|||||||
and the PR's agent author (in practice, the operator) has joined the
|
author comments (in practice, the operator has joined the discussion), and when
|
||||||
discussion. A push doesn't.
|
the PR gets a new push: new code is worth a fresh look.
|
||||||
|
|
||||||
### R3. Authority and reach
|
### R3. Authority and reach
|
||||||
|
|
||||||
|
|||||||
Reference in new issue
Block a user
Done: the count now resets on a new push too, since new code is worth a fresh look. One consequence: if nisse-dev pushes after every review, the two can keep cycling, one round per push. Your
stopon the PR still ends it, and M7.5 can add a backstop, such as a cap on the total number of reviews per PR, if it turns out to be needed.