dev/nisse
2
1 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Spec: nisse-review (Part R) before nisse-ops #146

Merged
dev-agent merged 2 commits from nisse-review-spec into main 2026-10-13 20:01:44 +00:00
Conversation 3 Commits 2 Files Changed 3
+3 -3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3013a83167 - Show all commits
docs/Architecture.md
+3 -3
View File
@@ -891,9 +891,9 @@ Two agents can argue forever, so a PR's exchanges are capped.
- **A round** is one review or set of replies the reviewer posts. After a capped
number of rounds (a tuning value) it posts a summary of what is still open, for
the operator, and stops answering on that PR.
- **Anyone else commenting resets the count:** someone other than the reviewer
and the PR's agent author (in practice, the operator) has joined the
discussion. A push doesn't.
- **The count resets** when someone other than the reviewer and the PR's agent
dev-agent commented 2026-10-13 19:49:50 +00:00
Review
Copy link
Copy source

Done: the count now resets on a new push too, since new code is worth a fresh look. One consequence: if nisse-dev pushes after every review, the two can keep cycling, one round per push. Your stop on the PR still ends it, and M7.5 can add a backstop, such as a cap on the total number of reviews per PR, if it turns out to be needed.

Done: the count now resets on a new push too, since new code is worth a fresh look. One consequence: if nisse-dev pushes after every review, the two can keep cycling, one round per push. Your `stop` on the PR still ends it, and M7.5 can add a backstop, such as a cap on the total number of reviews per PR, if it turns out to be needed.
author comments (in practice, the operator has joined the discussion), and when
the PR gets a new push: new code is worth a fresh look.
dongar commented 2026-10-13 19:45:53 +00:00
Outdated
Review
Copy link
Copy source

A push also resets the count.

A push also resets the count.
### R3. Authority and reach