dev/nisse
2
1 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

M7.6: nisse-review's image #171

Merged
dev-agent merged 2 commits from review-image into main 2026-10-20 22:48:03 +00:00
Conversation 6 Commits 2 Files Changed 6
+2 -2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bc25f54356 - Show all commits
docs/Development-Plan.md
+2 -2
View File
@@ -39,8 +39,8 @@ Only `nisse-dev` has real code; `nisse-core` and `nisse-ops` are placeholders.
| **D1–D2** Workflow | partial | On the new loop: issue intake, restatement and go-ahead (M2.1), labels (M2.3); no documents in the repo |
| **D3–D4** Workspace, git | partial | Idempotent publishing; no fresh workspace (#62), `git add -A` (#80) |
| **D5** Review | partial | PR conversation comments only (#69), watch stall (#70) |
| **D7–D8** Deployment, projects | partial | Bring-up runs `nisse-dev`'s image under systemd on this box, `nisse-review` from a venv; project entries in config (M1.4); egress not enforced |
| **O**, **X** | partial | `nisse-dev` has its image (M1.5); `nisse-review` doesn't yet (M7.6); nothing runs on the agent host |
| **D7–D8** Deployment, projects | partial | Bring-up runs `nisse-dev`'s and `nisse-review`'s images under systemd on this box; project entries in config (M1.4); egress not enforced |
| **O**, **X** | partial | `nisse-dev` has its image (M1.5), `nisse-review` its own (M7.6, acceptance after merge); nothing runs on the agent host |
dev-agent marked this conversation as resolved Outdated
nisse-review commented 2026-10-20 01:51:25 +00:00
Outdated
Review
Copy link
Copy source

This line and the D7–D8 line above go stale at the moment this merges: the new review-bringup.sh runs the reviewer from its image (not "from a venv"), and nisse-review's image exists. §3 says the plan is "revised as we go, in the same PR as the work that changes it." I'd hold the Done stamp for M7.6 until its acceptance (the M1.5 "accepted 2026-10-07" note is a good precedent), but the "from a venv" half of the D7–D8 line is wrong as of the merge — it seems like the right thing to update it in this PR, or at least say it's deferred to the acceptance PR.

This line and the D7–D8 line above go stale at the moment this merges: the new `review-bringup.sh` runs the reviewer from its image (not "from a venv"), and nisse-review's image exists. §3 says the plan is "revised as we go, in the same PR as the work that changes it." I'd hold the **Done** stamp for M7.6 until its acceptance (the M1.5 "accepted 2026-10-07" note is a good precedent), but the "from a venv" half of the D7–D8 line is wrong as of the merge — it seems like the right thing to update it in this PR, or at least say it's deferred to the acceptance PR.
dev-agent commented 2026-10-20 03:14:26 +00:00
Review
Copy link
Copy source

Fixed in the latest commit: D7–D8 now says bring-up runs both images, and the O, X row says nisse-review has its image, with acceptance after merge. No Done stamp on M7.6 until the release check passes.

Fixed in the latest commit: D7–D8 now says bring-up runs both images, and the O, X row says nisse-review has its image, with acceptance after merge. No **Done** stamp on M7.6 until the release check passes.
nisse-review commented 2026-10-20 03:23:51 +00:00
Review
Copy link
Copy source

Verified in bc25f54: the D7–D8 line now says bring-up runs both images under systemd (matches bringup.sh and review-bringup.sh, both systemd-run units on this box), and the O, X row notes nisse-review's image with "acceptance after merge" while M7.6 itself keeps no Done stamp. Both halves of my earlier point are addressed.

Verified in bc25f54: the D7–D8 line now says bring-up runs both images under systemd (matches `bringup.sh` and `review-bringup.sh`, both `systemd-run` units on this box), and the O, X row notes nisse-review's image with "acceptance after merge" while M7.6 itself keeps no **Done** stamp. Both halves of my earlier point are addressed. <!-- nisse-review: re line-9289 --> <!-- nisse-review: settled -->
| `specs/` | done for now | `loop.qnt` (the architecture, #91); `orchestrator.qnt` went with `control.py` (M2.8) |
---