dongarandClaude Opus 5.5
59fba3bb76
The live review test sets ci_grace_s: 0, which the shared tuning parser
refused (every number had to be positive). A field now opts in to zero
with metadata {"zero": True}; ci_wait_s and ci_grace_s do.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
83 lines
2.8 KiB
Python
83 lines
2.8 KiB
Python
"""Configuration any agent builds on: references resolved from the
|
|
environment, people lists, tuning sections of the agent's own, the LLM's
|
|
numbers, and the vault; every problem collected, none raised one by one."""
|
|
|
|
from dataclasses import dataclass, field
|
|
from pathlib import Path
|
|
|
|
from nisse_core.config import (
|
|
flatten,
|
|
llm_numbers,
|
|
parse_tuning,
|
|
parse_vault,
|
|
people,
|
|
resolve,
|
|
)
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class Review:
|
|
max_rounds: int = 3
|
|
wait_s: float = 60.0
|
|
grace_s: float = field(default=5.0, metadata={"zero": True})
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class Tuning:
|
|
review: Review = field(default_factory=Review)
|
|
|
|
|
|
def test_an_agents_own_tuning_sections() -> None:
|
|
errors: list[str] = []
|
|
tuning = parse_tuning({"review": {"max_rounds": 2}}, Tuning, errors)
|
|
assert tuning == Tuning(Review(max_rounds=2)) and errors == []
|
|
assert parse_tuning(None, Tuning, errors) == Tuning()
|
|
parse_tuning(
|
|
{"review": {"max_rounds": 0, "x": 1}, "old": {}, "new": {}},
|
|
Tuning,
|
|
errors,
|
|
retired={"old": "use review"},
|
|
)
|
|
assert errors == [
|
|
"tuning.review.max_rounds: must be a positive number",
|
|
"tuning.review.x: unknown setting",
|
|
"tuning.old: retired — use review",
|
|
"tuning.new: unknown section",
|
|
]
|
|
|
|
|
|
def test_a_field_may_opt_in_to_zero() -> None:
|
|
errors: list[str] = []
|
|
tuning = parse_tuning({"review": {"grace_s": 0}}, Tuning, errors)
|
|
assert tuning.review.grace_s == 0 and errors == []
|
|
parse_tuning({"review": {"grace_s": -1, "wait_s": 0}}, Tuning, errors)
|
|
assert errors == [
|
|
"tuning.review.grace_s: must be zero or more",
|
|
"tuning.review.wait_s: must be a positive number",
|
|
]
|
|
|
|
|
|
def test_references_and_people() -> None:
|
|
errors: list[str] = []
|
|
env = {"TOKEN": "s3cret"}
|
|
assert resolve("${TOKEN}", "gitea.token", env, errors) == "s3cret"
|
|
resolve("${NOPE}", "llm.token", env, errors)
|
|
assert errors == ["llm.token: references ${NOPE}, which is unset or empty"]
|
|
assert people("don, ,ann,") == {"don", "ann"}
|
|
assert flatten({"llm": {"base_url": "u"}, "tuning": {"a": {}}}) == {
|
|
"llm.base_url": "u",
|
|
"tuning": {"a": {}},
|
|
}
|
|
|
|
|
|
def test_llm_numbers_and_the_vault(tmp_path: Path) -> None:
|
|
errors: list[str] = []
|
|
assert llm_numbers({"llm.max_output_tokens": 100}, errors)[0] == 100
|
|
llm_numbers({"llm.request_timeout_s": -1}, errors)
|
|
assert errors == ["llm.request_timeout_s: must be a positive number of seconds"]
|
|
vault = parse_vault({"root": str(tmp_path), "folders": {"notes": "ro"}}, [])
|
|
assert vault is not None and vault.folders == {"notes": "ro"}
|
|
bad: list[str] = []
|
|
assert parse_vault({"root": "/v", "folders": {"../x": "rw"}}, bad) is None
|
|
assert bad == ["vault.folders.../x: a folder inside the vault"]
|