dongarandClaude Opus 5
2fb25b8195
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 1m14s
Nothing had ever assembled the agent. main.py was still the hello-world placeholder from the scaffold, and no code outside the test suite constructed an Orchestrator — which is how two fully built, fully tested components came to be reachable from nothing: the delegation harness, and the Gitea comment poller. Unit tests that construct a component directly cannot catch that; only assembly can. - config.py validates every variable before anything is built and names all of them at once, rather than failing at first use twenty minutes into a milestone on the call that mattered. Whitespace-only counts as missing, since a token of spaces passes a truthiness check and fails at the first request instead - agent.py builds the whole graph and owns startup and shutdown order: reconcile before accepting commands, and on stop, stop watching, then stop talking, then close the store last - The Gitea account is read via whoami rather than configured: it names the identity every permission is evaluated against, and proves the token works before anything depends on it - Poller lifecycle is now a state-machine concern: watch the plan issue while a gate stands, the PR while it is open, and stop on leaving. The orchestrator owns when to watch; an injected factory owns how to build one - The executor reports each turn, because it runs synchronously inside the transport callback: without it the agent is silent for a whole milestone and a working run looks exactly like a hung one - main.py loads .env, builds, and shuts down cleanly on SIGINT/SIGTERM The entry-point tests changed shape: nisse-dev no longer greets, it refuses to start unconfigured and says everything that is missing. Both tests now run with a deliberately empty environment and a .env path that does not exist, because the working directory's .env holds live credentials and a test must never be one cwd away from starting a real agent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
92 lines
3.1 KiB
Python
92 lines
3.1 KiB
Python
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from nisse_dev.config import AgentConfig, ConfigError
|
|
|
|
COMPLETE = {
|
|
"NISSE_STATE_DB": "~/demo/state.db",
|
|
"NISSE_WORKSPACE": "~/demo/work",
|
|
"NISSE_PROJECT": "greet",
|
|
"NISSE_LLM_BASE_URL": "https://litellm.test",
|
|
"NISSE_LLM_TOKEN": "sk-x",
|
|
"NISSE_ROLE_EXECUTOR": "claude-haiku-4-5",
|
|
"NISSE_ROLE_PLANNER": "claude-opus-5",
|
|
"NISSE_ROLE_DELEGATE": "claude-opus-5",
|
|
"NISSE_ROLE_CONSULTANT": "claude-haiku-4-5",
|
|
"NISSE_MATRIX_HOMESERVER": "https://matrix.test",
|
|
"NISSE_MATRIX_USER_ID": "@nisse-dev-testing:test",
|
|
"NISSE_MATRIX_TOKEN": "syt_x",
|
|
"NISSE_MATRIX_ROOM_ID": "!room:test",
|
|
"NISSE_MATRIX_OPERATORS": "@don:test",
|
|
"NISSE_GITEA_URL": "https://gitea.test",
|
|
"NISSE_GITEA_TOKEN": "gt",
|
|
"NISSE_GITEA_REPO": "don/demo",
|
|
"NISSE_GITEA_OPERATORS": "don",
|
|
}
|
|
|
|
|
|
def test_complete_environment_builds() -> None:
|
|
config = AgentConfig.from_env(COMPLETE)
|
|
assert config.project == "greet"
|
|
assert config.roles.planner == "claude-opus-5"
|
|
assert config.matrix.room_id == "!room:test"
|
|
assert config.gitea_repo == "don/demo"
|
|
assert config.base_branch == "main"
|
|
|
|
|
|
def test_paths_expand_the_home_directory() -> None:
|
|
config = AgentConfig.from_env(COMPLETE)
|
|
assert config.workspace.is_absolute()
|
|
assert "~" not in str(config.state_db)
|
|
|
|
|
|
def test_every_missing_variable_is_reported_at_once() -> None:
|
|
# Failing at first use would surface a missing token twenty minutes into
|
|
# a milestone, on the call that mattered.
|
|
partial = {k: v for k, v in COMPLETE.items() if k != "NISSE_MATRIX_TOKEN"}
|
|
partial.pop("NISSE_GITEA_REPO")
|
|
with pytest.raises(ConfigError) as excinfo:
|
|
AgentConfig.from_env(partial)
|
|
message = str(excinfo.value)
|
|
assert "NISSE_MATRIX_TOKEN" in message
|
|
assert "NISSE_GITEA_REPO" in message
|
|
|
|
|
|
def test_empty_is_treated_as_missing() -> None:
|
|
with pytest.raises(ConfigError, match="NISSE_GITEA_TOKEN"):
|
|
AgentConfig.from_env({**COMPLETE, "NISSE_GITEA_TOKEN": " "})
|
|
|
|
|
|
def test_operator_lists_are_split_and_trimmed() -> None:
|
|
config = AgentConfig.from_env(
|
|
{
|
|
**COMPLETE,
|
|
"NISSE_MATRIX_OPERATORS": " @don:test , @other:test ,",
|
|
"NISSE_GITEA_OPERATORS": "don,",
|
|
}
|
|
)
|
|
assert config.operators == {"@don:test", "@other:test"}
|
|
# A trailing comma must not admit an empty identity into an allowlist.
|
|
assert "" not in config.operators
|
|
assert config.gitea_operators == {"don"}
|
|
|
|
|
|
def test_base_branch_is_overridable() -> None:
|
|
config = AgentConfig.from_env({**COMPLETE, "NISSE_BASE_BRANCH": "trunk"})
|
|
assert config.base_branch == "trunk"
|
|
|
|
|
|
def test_redacted_summary_carries_no_secrets() -> None:
|
|
summary = AgentConfig.from_env(COMPLETE).redacted()
|
|
flat = " ".join(summary.values())
|
|
for secret in ("sk-x", "syt_x", "gt"):
|
|
assert secret not in flat
|
|
assert summary["project"] == "greet"
|
|
|
|
|
|
def test_state_db_and_workspace_are_separate(tmp_path: Path) -> None:
|
|
# A2: build artefacts must not share a volume with agent state.
|
|
config = AgentConfig.from_env(COMPLETE)
|
|
assert config.state_db.parent != config.workspace
|