dongarandClaude Opus 5.5
6ae2375194
nisse-dev now runs only the conversational loop. The gated state machine it was built alongside is gone: - Removed control.py, planner.py, executor.py, approvals.py, gates.py (command_form moves to loop/reader.py), publish.py and poller.py, the old assembly in agent.py (its shared helpers move to loop/build.py), the store's state-machine view (get_state, transition), their tests, the old end-to-end and live planning/milestone/gate tests, and specs/orchestrator.qnt with its scenarios. - Roles are driver, helper, expert and classifier; driver is required. loop:, roles.planner, roles.executor and tuning.executor are refused with what to use instead; tuning.driver takes the turn cap and failure limit. - The benchmark and the capability matrix measure the driver: the loop's own system prompt and tools, the task's plan as the agreed restatement. Task plans end with finish_milestone, so earlier runs show as (old); stored runs' executor tuning reads as the driver's. - A delegation on the loop records what its helper's alias resolved to (L9), as the old path's did. - The dump shows a work item's revision and what it waits for. - Behaviour the old tests covered and the loop shares stays covered: driver runs that fail on a model call, stop mid-turn, reset the failure count; go-aheads ignoring case and punctuation; a request too big to fit is never sent; the assembly tests, now on build_loop_agent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE
81 lines
2.8 KiB
Python
81 lines
2.8 KiB
Python
import io
|
|
from pathlib import Path
|
|
|
|
from nisse_dev.canonical import Fact, PlanSubmitted, ToolCall, ToolResult, UserMessage
|
|
from nisse_dev.dump import main, render
|
|
from nisse_dev.oplog import OpLog
|
|
from nisse_dev.state import StateStore
|
|
|
|
|
|
def store_with_a_run(path: Path) -> None:
|
|
store = StateStore(path, oplog=OpLog("nisse-dev", io.StringIO()))
|
|
store.transcript(None, "operator").append(
|
|
UserMessage(text="hello before use", source="matrix")
|
|
)
|
|
store.open_work_item(
|
|
"demo-1",
|
|
title="Add a truncate helper",
|
|
scope="demo",
|
|
position="WAITING",
|
|
data={"loop": {"wait": "go-ahead", "rev": 1}},
|
|
cause="test",
|
|
)
|
|
store.set_active("demo-1", cause="test")
|
|
log = store.transcript("demo-1", "operator")
|
|
log.append(UserMessage(text="Add a truncate helper", source="matrix"))
|
|
driver = log.as_actor("driver")
|
|
driver.append(PlanSubmitted(plan="x" * 500, model="opus"))
|
|
driver.append(
|
|
ToolCall(call_id="c1", tool="run_command", arguments={"command": "ls"})
|
|
)
|
|
driver.append(ToolResult(call_id="c1", result="README.md", success=False))
|
|
log.begin_intent("open_pr", {"branch": "b"}, cause="test")
|
|
store.close()
|
|
|
|
|
|
def test_the_dump_shows_items_intents_and_each_event_with_its_actor(
|
|
tmp_path: Path,
|
|
) -> None:
|
|
db = tmp_path / "state.db"
|
|
store_with_a_run(db)
|
|
text = render(db)
|
|
assert "active work item: demo-1" in text
|
|
assert (
|
|
"demo-1 open position: WAITING scope: demo rev-1 waits for: go-ahead"
|
|
in text
|
|
)
|
|
assert "pending intent #1 open_pr [demo-1]" in text
|
|
assert "[agent/operator] USER [matrix]: hello before use" in text
|
|
assert "[demo-1/operator] USER [matrix]: Add a truncate helper" in text
|
|
assert "[demo-1/driver] PLAN (opus, 500 chars): " in text and "[340 more]" in text
|
|
assert '[demo-1/driver] CALL run_command {"command": "ls"}' in text
|
|
assert "result (FAILED): README.md" in text
|
|
|
|
|
|
def test_full_shows_long_texts_whole(tmp_path: Path) -> None:
|
|
db = tmp_path / "state.db"
|
|
store_with_a_run(db)
|
|
assert "x" * 500 in render(db, full=True)
|
|
|
|
|
|
def test_facts_are_shown_as_the_orchestrators(tmp_path: Path) -> None:
|
|
db = tmp_path / "state.db"
|
|
store_with_a_run(db)
|
|
store = StateStore(db, oplog=OpLog("nisse-dev", io.StringIO()))
|
|
store.transcript("demo-1", "orchestrator").append(Fact(text="PR #3 opened"))
|
|
store.close()
|
|
assert "[demo-1/orchestrator] FACT: PR #3 opened" in render(db)
|
|
|
|
|
|
def test_the_dump_never_writes_to_the_store(tmp_path: Path) -> None:
|
|
db = tmp_path / "state.db"
|
|
store_with_a_run(db)
|
|
before = db.read_bytes()
|
|
render(db)
|
|
assert db.read_bytes() == before
|
|
|
|
|
|
def test_a_missing_store_is_reported(tmp_path: Path, capsys) -> None:
|
|
assert main([str(tmp_path / "nope.db")]) == 1
|
|
assert "no state store" in capsys.readouterr().err
|