dongarandClaude Opus 5.5
15d69799bf
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 51s
With no production instance yet, there is no reason to carry two ways
of configuring the agent. Every environment variable that duplicated a
config key is gone; the environment now supplies only the secrets the
file references by ${…}, plus NISSE_CONFIG and NISSE_ENV to find the
files.
- AgentConfig loads from a file (load, from_file) or a parsed tree
(from_tree, for tests); a missing file is an error naming the example
- The from_env constructors on LiteLLMClient, AnthropicPassthroughClient,
GiteaClient, MatrixConfig and RoleMap are removed, with the env
reading for max output tokens; clients take their settings from config
- The live integration tests share a committed agent config,
tests/integration/nisse-test.yaml, aimed at test resources, and one
conftest that loads it and builds clients. NISSE_LIVE_PLANNER_MODEL
becomes its planner role; NISSE_CAPABILITY_MODELS stays as a per-run
switch
- A missing secret now fails the live tests instead of skipping them
- CI passes only the three tokens
- .env.example is secrets only; spec A5 says config comes from the file
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
94 lines
3.1 KiB
Python
94 lines
3.1 KiB
Python
"""Live Gitea round trip against the sandbox repo: push a branch, open a PR,
|
|
comment, and prove the A3 reconciler reads external truth correctly.
|
|
|
|
Cleans up after itself (closes the PR, deletes the branch) so repeated runs
|
|
do not silt up the sandbox.
|
|
"""
|
|
|
|
import uuid
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from nisse_dev.config import AgentConfig
|
|
from nisse_dev.git import GitError, GitRepo, authenticated_url
|
|
from nisse_dev.gitea import GiteaClient, pull_request_reconciler
|
|
from nisse_dev.state import Intent
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
def intent_for(branch: str) -> Intent:
|
|
return Intent(
|
|
id=1,
|
|
kind="open_pr",
|
|
payload={"branch": branch},
|
|
status="pending",
|
|
created_at="t",
|
|
resolved_at=None,
|
|
)
|
|
|
|
|
|
def test_push_open_pr_and_reconcile(
|
|
tmp_path: Path, live_config: AgentConfig, gitea: GiteaClient
|
|
) -> None:
|
|
base_url = live_config.gitea_url
|
|
token = live_config.gitea_token
|
|
repo_path = live_config.gitea_repo # the sandbox
|
|
client = gitea
|
|
|
|
account = client.whoami()
|
|
assert "testing" in account, (
|
|
f"live tests must run as a testing account, not {account}"
|
|
)
|
|
|
|
branch = f"live-test-{uuid.uuid4().hex[:8]}"
|
|
reconcile = pull_request_reconciler(client, repo_path)
|
|
|
|
# Before the PR exists, external truth says the effect has not happened.
|
|
assert reconcile(intent_for(branch)) is False
|
|
|
|
repo = GitRepo(tmp_path / "work")
|
|
repo.init()
|
|
repo.configure_identity(account, f"{account}@example.test")
|
|
(repo.root / f"{branch}.txt").write_text("live test artifact\n")
|
|
assert repo.commit_all("Live test commit") is not None
|
|
|
|
url = authenticated_url(base_url, repo_path, account, token)
|
|
pr = None
|
|
try:
|
|
repo.push(url, branch, token=token)
|
|
pr = client.open_pull_request(
|
|
repo_path,
|
|
head=branch,
|
|
base="main",
|
|
title=f"live test {branch}",
|
|
body="Opened by the nisse-dev live test suite.",
|
|
)
|
|
assert pr.head == branch
|
|
|
|
client.post_comment(repo_path, pr.number, "live test comment")
|
|
bodies = [c.body for c in client.list_comments(repo_path, pr.number)]
|
|
assert "live test comment" in bodies
|
|
|
|
# Now the same reconciler must see the effect and refuse to repeat it.
|
|
assert reconcile(intent_for(branch)) is True
|
|
|
|
# A4 is only real if the server enforces it. The agent's own token
|
|
# must not be able to merge the PR it just opened, and must not be
|
|
# able to push to the protected default branch at all.
|
|
merged = client._http.post(
|
|
f"/repos/{repo_path}/pulls/{pr.number}/merge", json={"Do": "merge"}
|
|
)
|
|
assert merged.status_code >= 400, (
|
|
"the agent merged its own PR: branch protection is not enforcing "
|
|
"the human gate"
|
|
)
|
|
with pytest.raises(GitError):
|
|
repo.push(url, "main", token=token)
|
|
finally:
|
|
if pr is not None:
|
|
client.close_pull_request(repo_path, pr.number)
|
|
repo.delete_remote_branch(url, branch, token=token)
|
|
client.close()
|