dongarandClaude Opus 5.5
6ae2375194
nisse-dev now runs only the conversational loop. The gated state machine it was built alongside is gone: - Removed control.py, planner.py, executor.py, approvals.py, gates.py (command_form moves to loop/reader.py), publish.py and poller.py, the old assembly in agent.py (its shared helpers move to loop/build.py), the store's state-machine view (get_state, transition), their tests, the old end-to-end and live planning/milestone/gate tests, and specs/orchestrator.qnt with its scenarios. - Roles are driver, helper, expert and classifier; driver is required. loop:, roles.planner, roles.executor and tuning.executor are refused with what to use instead; tuning.driver takes the turn cap and failure limit. - The benchmark and the capability matrix measure the driver: the loop's own system prompt and tools, the task's plan as the agreed restatement. Task plans end with finish_milestone, so earlier runs show as (old); stored runs' executor tuning reads as the driver's. - A delegation on the loop records what its helper's alias resolved to (L9), as the old path's did. - The dump shows a work item's revision and what it waits for. - Behaviour the old tests covered and the loop shares stays covered: driver runs that fail on a model call, stop mid-turn, reset the failure count; go-aheads ignoring case and punctuation; a request too big to fit is never sent; the assembly tests, now on build_loop_agent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE
84 lines
2.4 KiB
Python
84 lines
2.4 KiB
Python
import io
|
|
import threading
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from nisse_dev.oplog import OpLog
|
|
from nisse_dev.state import StateStore
|
|
from nisse_dev.worker import InlineWorker, SerialWorker
|
|
|
|
|
|
@pytest.fixture
|
|
def worker() -> SerialWorker:
|
|
w = SerialWorker()
|
|
w.start()
|
|
yield w
|
|
w.stop(timeout=5)
|
|
|
|
|
|
def test_jobs_run_in_order_on_the_worker_thread(worker: SerialWorker) -> None:
|
|
seen: list[tuple[int, str]] = []
|
|
for n in range(3):
|
|
worker.submit(lambda n=n: seen.append((n, threading.current_thread().name)))
|
|
worker.call(lambda: None) # drains everything queued before it
|
|
|
|
assert [n for n, _ in seen] == [0, 1, 2]
|
|
assert {name for _, name in seen} == {"nisse-worker"}
|
|
|
|
|
|
def test_call_returns_the_result_and_raises_the_error(worker: SerialWorker) -> None:
|
|
assert worker.call(lambda: 42) == 42
|
|
|
|
def boom() -> None:
|
|
raise ValueError("bad job")
|
|
|
|
with pytest.raises(ValueError, match="bad job"):
|
|
worker.call(boom)
|
|
|
|
|
|
def test_a_failed_job_is_reported_and_the_worker_carries_on() -> None:
|
|
errors: list[BaseException] = []
|
|
worker = SerialWorker(on_error=errors.append)
|
|
worker.start()
|
|
|
|
def boom() -> None:
|
|
raise RuntimeError("lost job")
|
|
|
|
worker.submit(boom)
|
|
assert worker.call(lambda: "still here") == "still here"
|
|
assert [str(e) for e in errors] == ["lost job"]
|
|
worker.stop(timeout=5)
|
|
|
|
|
|
def test_call_from_the_worker_itself_runs_inline(worker: SerialWorker) -> None:
|
|
# Queueing behind itself would deadlock.
|
|
assert worker.call(lambda: worker.call(lambda: "nested")) == "nested"
|
|
|
|
|
|
def test_the_store_is_usable_only_from_the_thread_that_owns_it(
|
|
worker: SerialWorker, tmp_path: Path
|
|
) -> None:
|
|
store = worker.call(
|
|
lambda: StateStore(tmp_path / "state.db", oplog=OpLog("t", io.StringIO()))
|
|
)
|
|
assert worker.call(store.active_item) is None
|
|
# The tripwire the worker design keeps on: any other thread fails loudly.
|
|
with pytest.raises(Exception, match="same thread"):
|
|
store.active_item()
|
|
worker.call(store.close)
|
|
|
|
|
|
def test_inline_worker_defers_a_job_submitted_from_inside_a_job() -> None:
|
|
worker = InlineWorker()
|
|
order: list[str] = []
|
|
|
|
def outer() -> None:
|
|
order.append("outer start")
|
|
worker.submit(lambda: order.append("inner"))
|
|
order.append("outer end")
|
|
|
|
worker.submit(outer)
|
|
assert order == ["outer start", "outer end", "inner"]
|
|
assert not worker.busy
|