The publisher commits build artifacts into PRs (git add -A) #80

New Issue

2026-09-30T12:58:07Z

dev-agent commented

2026-09-30 12:58:07 +00:00

Found on the second live run.

After the executor finished, MilestonePublisher.publish → GitRepo.commit_all ran git add -A. This committed the untracked __pycache__/*.pyc files left by running the tests: 5 binary files, as a separate "Milestone N: …" commit on both PRs (#165, #166). The executor had noticed them and deliberately left them out of its own commit ("incidental __pycache__/ dirs from running pytest — build artifacts, not edits"). The publisher then added them anyway. The sandbox repo has no .gitignore, which is normal for a young project.

Expected: never commit build artifacts into a PR.

Standard excludes in the workspace's .git/info/exclude, written when the workspace is prepared: __pycache__/, *.py[co], .pytest_cache/, .ruff_cache/, .mypy_cache/, node_modules/, *.egg-info/, .venv/. This file is local to the clone (never committed), so it doesn't change the project, and it's cheap.
And/or commit only what the executor changed: the paths it wrote (write_file) plus changes to tracked files, never arbitrary untracked files. This is stricter, and catches artifacts nobody predicted.
Report anything excluded in the milestone note, so nothing is lost silently.

Test: a milestone that runs pytest leaves __pycache__, and the published branch contains no .pyc.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE

Found on the second live run. After the executor finished, `MilestonePublisher.publish` → `GitRepo.commit_all` ran `git add -A`. This committed the untracked `__pycache__/*.pyc` files left by running the tests: 5 binary files, as a separate "Milestone N: …" commit on **both** PRs (#165, #166). The executor had noticed them and deliberately left them out of its own commit ("incidental `__pycache__/` dirs from running pytest — build artifacts, not edits"). The publisher then added them anyway. The sandbox repo has no `.gitignore`, which is normal for a young project. **Expected:** never commit build artifacts into a PR. - **Standard excludes in the workspace's `.git/info/exclude`,** written when the workspace is prepared: `__pycache__/`, `*.py[co]`, `.pytest_cache/`, `.ruff_cache/`, `.mypy_cache/`, `node_modules/`, `*.egg-info/`, `.venv/`. This file is local to the clone (never committed), so it doesn't change the project, and it's cheap. - **And/or commit only what the executor changed:** the paths it wrote (`write_file`) plus changes to tracked files, never arbitrary untracked files. This is stricter, and catches artifacts nobody predicted. - **Report anything excluded** in the milestone note, so nothing is lost silently. **Test:** a milestone that runs pytest leaves `__pycache__`, and the published branch contains no `.pyc`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PPQ14L3LikyefCMFBqEbKE

dev-agent referenced this issue

2026-09-30 13:02:04 +00:00

A milestone that legitimately changes nothing has no way forward #81

dev-agent referenced this issue

2026-09-30 21:06:14 +00:00

Propose the Development Plan #84

dev-agent referenced this issue

2026-10-02 19:41:48 +00:00

Rework the Development Plan around live testing #92

dev-agent referenced this issue from a commit

2026-10-02 22:38:14 +00:00

Publish only the work: leave build artifacts out and report them (#80)