nisse-review: a new head's review waits for its CI #155

Merged

dev-agent merged 4 commits from review-waits-for-ci into main 2026-10-17 04:47:09 +00:00

Conversation 6 Commits 4 Files Changed 12

+241 -14

4 Commits

Author	SHA1	Message	Date
dongarandClaude Opus 5.5	637761ba5a	nisse-review: a retried or recovered review keeps its head's CI wait ... From nisse-review's own review of #155: a failed run, a posted one and crash recovery rebuilt the item without seen_at, so a retry skipped the CI wait. seen_at now carries through, renewed when the head moved during the review. Also: a test for checks Gitea can't report, and the example config lists ci_wait_s and ci_grace_s. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk	2026-10-17 04:35:05 +00:00
dongarandClaude Opus 5.5	59fba3bb76	Tuning: the CI waits may be zero ... The live review test sets ci_grace_s: 0, which the shared tuning parser refused (every number had to be positive). A field now opts in to zero with metadata {"zero": True}; ci_wait_s and ci_grace_s do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk	2026-10-17 04:33:52 +00:00
dongarandClaude Opus 5.5	096eeea56b	Live review test: no CI grace in its CI-less repository ... The CI wait made a head with no checks wait ci_grace_s (2 min), so the live test's single round reviewed nothing. Its fresh repository has no CI: the test sets the grace to 0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk	2026-10-17 00:02:18 +00:00
dongarandClaude Opus 5.5	be5ea5f170	nisse-review: a new head's review waits for its CI ... A review judges the CI result (R1), so a new head's review now waits while its checks are pending, and starts once they finish, passed or failed. It also keeps reviews off a GPU that CI is using: #154's first review ran beside CI's end-to-end job and took about 30 minutes. - Pending: waits up to tuning.review.ci_wait_s (1 h), then reviews anyway. - No checks: waits tuning.review.ci_grace_s (2 min) for them to appear, then reviews. - A PR waiting on CI holds up no other: the oldest settled one goes first. - The head's first sighting is kept on the item (seen_at). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk	2026-10-16 23:08:46 +00:00