dev/nisse
2
1 Fork 0
Code Issues 23 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Trust test: wait for Gitea to dismiss a stale approval before merging (#162) #164

Merged
dev-agent merged 2 commits from flaky-stale-approval into main 2026-10-18 13:23:25 +00:00
Conversation 5 Commits 2 Files Changed 2
+47 -3
2 Commits
Author SHA1 Message Date
dongarandClaude Opus 5.5 a1eeab1bc7 test_trust_live: ride out a transient Gitea error while waiting for the dismissal
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 1m55s
Details
CI / e2e (pull_request) Successful in 4m45s
Details 
A dropped connection or a 5xx inside the wait is retried until the
deadline; any other error fails at once (review on #164).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
 2026-10-18 13:16:10 +00:00
dongarandClaude Opus 5.5 63ad679c8b Trust test: wait for Gitea to dismiss a stale approval before merging (#162)
CI / checks (push) Skipped
CI / checks (pull_request) Successful in 2m9s
Details
CI / e2e (pull_request) Successful in 4m40s
Details 
Gitea dismisses an approval made stale by a push in a job it queues on the
push (services/pull AddTestPullRequestTask, v28.1.0), and its merge check
counts approvals not yet dismissed. Measured here, the approval stands for
0.15-0.23 s after the push; the test's merge came a couple of API calls
later, so it usually lost the race, and once won it. The test now waits for
the dismissal, with a timeout, before expecting Gitea's refusal, and checks
the agent's own rule at once: the PR's head is read from the branch, so the
approval is for an older commit straight away.

Also notes in the Development Plan why the helper loop doesn't compact.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J5Utyfzw7gF7UhjRDEtjTk
 2026-10-18 04:27:59 +00:00